feat: fff for file search - #1426
Open
dmtrKovalenko wants to merge 1 commit into
Open
Conversation
dmtrKovalenko
commented
May 20, 2026
| target_compile_features(${TEST_TARGET} PUBLIC cxx_std_23) | ||
| endif() | ||
|
|
||
| # Standalone smoke test for the fff integration. Not gated on BUILD_TESTS, |
Author
There was a problem hiding this comment.
I've been using this for my local development, it is LLM generated, so keep your own judgement - I think before merge we should get rid of this
dmtrKovalenko
force-pushed
the
feat/fff
branch
2 times, most recently
from
May 20, 2026 20:14
19933f6 to
006d0ad
Compare
This is how it works: https://github.com/user-attachments/assets/b9627617-b274-4a38-9ca3-13d6e7c8e963 A few important descisions/questions: 1. fff doesn't persist the index, the index is extremely fast so I don't see a reason to vaste resources storing paths anywhere. The index lives per the scope of open window triggered by file search view open 2. fff uses databases for access patterns, I suppose a lot of people would be happy if we reuse their existing database, I added a logic for this. Though your recently accessed files feature is separate 3. The search open window now shows the amount of indexed files in real time, can revert this - just thinking this is cool This PR was done with assistance of Claude Opus 4.7
Author
|
On the current build? Hmm we should canonicalize the path probably |
Contributor
|
did some testing with it, and i mainly only have the following issues:
https://nest.rip/f/rcBEr (video's too large for github 10MB limit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how it works:
Screencast.From.2026-05-20.11-51-09.mp4
A few important descisions/questions: